Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unlimited assets REST API changes. #527

Merged
merged 6 commits into from Mar 17, 2022
Merged

Support unlimited assets REST API changes. #527

merged 6 commits into from Mar 17, 2022

Conversation

ghost
Copy link

@ghost ghost commented Feb 24, 2022

Add endpoints related to the unlimited assets changes.

@ghost ghost requested review from winder, jasonpaulos and cce February 24, 2022 18:35
@ghost ghost self-assigned this Feb 24, 2022
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like, at least, the round param has not been removed from the balances endpoint.

Have the model objects been generated? I don't see the creator field removed either.

@winder
Copy link
Contributor

winder commented Mar 7, 2022

The new tests need to be enabled: @unit.responses.unlimited_assets,@unit.indexer.ledger_refactoring,@unit.algod.ledger_refactoring

@ghost
Copy link
Author

ghost commented Mar 11, 2022

It looks like, at least, the round param has not been removed from the balances endpoint.

Have the model objects been generated? I don't see the creator field removed either.

How do I generate the model?

Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question. Changes look good, but the tests aren't passing.

@winder
Copy link
Contributor

winder commented Mar 17, 2022

@algochoi do you know anything about the build_and_test_chrome test? It seems to be flaky recently and we're not sure whats causing it.

@winder winder self-requested a review March 17, 2022 19:09
@algochoi
Copy link
Contributor

algochoi commented Mar 17, 2022

@winder At first glance, it looks like there is some version mismatch between our chromedriver versions:

SessionNotCreatedError: session not created: This version of ChromeDriver only supports Chrome version 97
Current browser version is 99.0.4844.74 with binary path /usr/bin/google-chrome

We used to manually update the version but @jasonpaulos recently merged a PR that should automatically update this. Perhaps try merging in the develop branch if you haven't done so already?

@winder winder changed the title Unlimited Assets Support unlimited assets REST API changes. Mar 17, 2022
@winder winder merged commit 44922a2 into algorand:develop Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants