-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support unlimited assets REST API changes. #527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like, at least, the round param has not been removed from the balances endpoint.
Have the model objects been generated? I don't see the creator field removed either.
The new tests need to be enabled: |
How do I generate the model? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question. Changes look good, but the tests aren't passing.
@algochoi do you know anything about the build_and_test_chrome test? It seems to be flaky recently and we're not sure whats causing it. |
@winder At first glance, it looks like there is some version mismatch between our chromedriver versions:
We used to manually update the version but @jasonpaulos recently merged a PR that should automatically update this. Perhaps try merging in the |
Add endpoints related to the unlimited assets changes.