Update chromedriver #535
Merged
Update chromedriver #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algochoi
approved these changes
Mar 7, 2022
There was a problem hiding this comment.
LGTM, minor comment below
- I checked the chromedriver package and there might be a new
99.0.0version as of yesterday. Not sure if it makes a difference.
|
Thanks, I'll update to that version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update chromedriver dependency to fix Chrome tests.
Since we have to update this pretty frequently to match the latest Chrome release, I've also added some code to automatically install the latest chromedriver in our CI process.