Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boxes for application calls in static array #573

Merged
merged 25 commits into from
Jun 30, 2022

Conversation

algochoi
Copy link
Contributor

@algochoi algochoi commented May 26, 2022

This PR includes support for the boxes field in appl transactions in the JS SDK.

Introduces EncodedBoxReference which represents the foreign array index and box name whereas BoxReference represents the app ID and box name, and what users will interact with in the transaction. The BoxReference is translated to its encoded counterpart before sent through the wire.

@algochoi algochoi requested a review from jdtzmn June 22, 2022 18:58
src/boxStorage.ts Show resolved Hide resolved
src/makeTxn.ts Show resolved Hide resolved
src/transaction.ts Outdated Show resolved Hide resolved
src/types/transactions/base.ts Show resolved Hide resolved
src/boxStorage.ts Show resolved Hide resolved
src/transaction.ts Outdated Show resolved Hide resolved
tests/5.Transaction.js Outdated Show resolved Hide resolved
@algochoi algochoi requested a review from jdtzmn June 27, 2022 20:26
Copy link
Contributor

@jdtzmn jdtzmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Just one optional minor change.

src/boxStorage.ts Outdated Show resolved Hide resolved
@algochoi algochoi merged commit a122ae1 into algorand:feature/box-storage Jun 30, 2022
@algochoi algochoi deleted the box-reference branch June 30, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants