Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box Storage: Add GetApplicationBoxes API and cucumber steps #608

Merged
merged 7 commits into from
Jul 15, 2022

Conversation

algochoi
Copy link
Contributor

This PR adds the GetApplicationBoxes API endpoint in the v2 algod client and adds cucumber integration tests.

@@ -1066,6 +1066,52 @@ export class Box extends BaseModel {
}
}

/**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is autogenerated from the spec

@jdtzmn jdtzmn self-requested a review July 13, 2022 20:45
Copy link
Contributor

@jdtzmn jdtzmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple optional changes.

src/client/v2/algod/getApplicationBoxes.ts Show resolved Hide resolved
tests/cucumber/steps/steps.js Outdated Show resolved Hide resolved
tests/cucumber/steps/steps.js Outdated Show resolved Hide resolved
@algochoi algochoi merged commit 293b4d2 into feature/box-storage Jul 15, 2022
@algochoi algochoi deleted the box-list-api branch July 15, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants