Enhancement: Use sandbox for SDK Testing and remove Indexer v1 steps #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzaffi
reviewed
Aug 16, 2022
tzaffi
reviewed
Aug 16, 2022
algochoi
changed the title
tzaffi
reviewed
Aug 16, 2022
There was a problem hiding this comment.
Looking good so far. Still expecting a few more mods (if JS is similar to Python).
Step removal:
then("I get transactions by address only")then("I can get the transaction by ID")when("I get recent transactions, limited by {cnt} transactions")then("I get transactions by address and date")
Step modification:
step("I wait for the transaction to be confirmed.")
|
@tzaffi I think I made all the necessary deletions now. For |
tzaffi
suggested changes
Aug 16, 2022
There was a problem hiding this comment.
I think the tests aren't running, unless I'm missing something?
That would explain how the algod step that I was surprised was removed didn't break the test.
|
tzaffi
reviewed
Aug 16, 2022
tzaffi
approved these changes
Aug 16, 2022
tzaffi
reviewed
Aug 17, 2022
tzaffi
reviewed
Aug 17, 2022
Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>
tzaffi
approved these changes
Aug 17, 2022
michaeldiamant
approved these changes
Aug 22, 2022
…hose steps (#627) * command to generate input for Unused Steps Analysis Script + Remove those steps * remvoe the steps * In response to CR remark. Update Makefile
tzaffi
reviewed
Aug 22, 2022
Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>
ahangsu
added a commit
that referenced
this pull request
Sep 3, 2022
* bump version and add to changelog * update README.md for new version * prettier on CHANGELOG * Update README.md Co-authored-by: John Lee <john.lee@algorand.com> * Update README.md Co-authored-by: John Lee <john.lee@algorand.com> * Enhancement: Use sandbox for SDK Testing and remove Indexer v1 steps (#623) * Add files to enable sandbox sdk testing * Add some todo comments and formatting * Update changes to script and env * Delete indexer v1 test steps * More changes to cucumber tests * Change features directory in JS SDK * Remove more indexer integration tests * Update test env * Update test-harness.sh Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * Break out cucumber tags into their own files (#625) * Command to generate input for Unused Steps Analysis Script + Remove those steps (#627) * command to generate input for Unused Steps Analysis Script + Remove those steps * remvoe the steps * In response to CR remark. Update Makefile * Update .test-env Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * Bugfix: Pass verbosity to the harness and sandbox (#630) * Ignore algorand-sdk-testing test-harness dir (#634) * Enhancement: Deprecating use of langspec (#632) * enhancement: Initial stateproofs support (#629) * Initial stateproofs support * Some more unused steps (#637) * dummy push * revert change of dummy push, ci runs now Co-authored-by: Barbara Poon <barbara.poon@algorand.com> Co-authored-by: algobarb <78746954+algobarb@users.noreply.github.com> Co-authored-by: John Lee <john.lee@algorand.com> Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com> Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> Co-authored-by: Eric Warehime <eric.warehime@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python SDK PR here: algorand/py-algorand-sdk#367