algod: Simulate Endpoint #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algochoi
commented
Feb 27, 2023
.test-env
Outdated
| @@ -1,6 +1,6 @@ | |||
| # Configs for testing repo download: | |||
| SDK_TESTING_URL="https://github.com/algorand/algorand-sdk-testing" | |||
| SDK_TESTING_BRANCH="master" | |||
| SDK_TESTING_BRANCH="simulate-endpoint-tests" | |||
There was a problem hiding this comment.
TODO: revert back to master
algochoi
commented
Mar 6, 2023
* Encode unsigned transactions for simulation * Implement unsigned txn simulate in ATC * Change test branch
tzaffi
reviewed
Mar 15, 2023
Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>
This reverts commit 474bbb4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
To support sending unsigned transactions to the simulate endpoint, also adds
encodeNoSigTransaction()to encode them. Currently, algod does not seem to decodeTransaction, so we wrap them in aSignedTransaction-like object, but set the sig field to null. For simulating unsigned txns in the ATC, addedmakeNoSigTransactionSignerto allow the transaction signer to encode unsigned transactions and simulate them.TODO:
@simulatetag)