-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
algod: Simulate Endpoint #743
Conversation
.test-env
Outdated
@@ -1,6 +1,6 @@ | |||
# Configs for testing repo download: | |||
SDK_TESTING_URL="https://github.com/algorand/algorand-sdk-testing" | |||
SDK_TESTING_BRANCH="master" | |||
SDK_TESTING_BRANCH="simulate-endpoint-tests" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: revert back to master
* Encode unsigned transactions for simulation * Implement unsigned txn simulate in ATC * Change test branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good. I had several possible nits and other very minor suggestions.
Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>
This reverts commit 474bbb4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR:
To support sending unsigned transactions to the simulate endpoint, also adds
encodeNoSigTransaction()
to encode them. Currently, algod does not seem to decodeTransaction
, so we wrap them in aSignedTransaction
-like object, but set the sig field to null. For simulating unsigned txns in the ATC, addedmakeNoSigTransactionSigner
to allow the transaction signer to encode unsigned transactions and simulate them.TODO:
@simulate
tag)