Break v2_step.py into account_, application_, and other_ #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
tzaffi
commented
Jun 3, 2022
| from algosdk import account, encoding, logic | ||
| from algosdk.future import transaction | ||
|
|
||
| import test.steps.other_v2_steps |
There was a problem hiding this comment.
This import is required to make MaybeString and MaybeBool which are defined in other_v2_steps available
tzaffi
commented
Jun 3, 2022
| import test.steps.other_v2_steps | ||
|
|
||
|
|
||
| def fund_account_address( |
There was a problem hiding this comment.
Move most helper functions to the top of the file
tzaffi
commented
Jun 3, 2022
| from test.steps.other_v2_steps import read_program | ||
|
|
||
|
|
||
| def operation_string_to_enum(operation): |
There was a problem hiding this comment.
Move most helper functions to the top of the file
tzaffi
commented
Jun 3, 2022
| @@ -67,6 +57,52 @@ def parse_bool(value): | |||
| register_type(MaybeBool=parse_bool) | |||
|
|
|||
|
|
|||
| def validate_error(context, err): | |||
There was a problem hiding this comment.
Move most helper functions to the top of the file
onetechnical
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring Cucumber Steps (V2 Only)
This PR is a NO-OP. Only code for testing is affected and the only changes amount to:
Details
v2_steps.pyhas gotten ginormous, which makes it harder to work with.The PR breaks up the file into:
test/steps/account_v2_steps.py- where most of the account-focused logic now residestest/steps/application_v2_steps.py- where most of the app-centric logic now residestest/steps/other_v2_steps.py- where miscellaneous other functionality including helper functions used by the other files residesTesting
All tests should continue passing