Box support for Application calls and Atomic Transaction Composer #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algochoi
commented
May 23, 2022
algochoi
commented
May 23, 2022
| @@ -7,7 +7,8 @@ pushd $rootdir | |||
|
|
|||
| # Reset test harness | |||
| rm -rf test-harness | |||
| git clone --single-branch --branch master https://github.com/algorand/algorand-sdk-testing.git test-harness | |||
| # TODO: Before merging, change branch back to master | |||
There was a problem hiding this comment.
TODO: Revert this back to master before merging
algochoi
commented
May 24, 2022
This was referenced May 25, 2022
tzaffi
reviewed
Jun 1, 2022
tzaffi
reviewed
Jun 2, 2022
tzaffi
reviewed
Jun 2, 2022
tzaffi
reviewed
Jun 2, 2022
tzaffi
reviewed
Jun 2, 2022
tzaffi
reviewed
Jun 2, 2022
tzaffi
reviewed
Jun 2, 2022
* Unit test for encoding.py's `encode_as_bytes()`
tzaffi
approved these changes
Jun 3, 2022
There was a problem hiding this comment.
I'm approving with the contingency that this shouldn't be merged until algorand/algorand-sdk-testing#181 has been merged, and that right before the merge of this py-algorand-sdk PR, the sdk branch referenced in run_integration.sh should point to feature/box-storage
tzaffi
reviewed
Jun 7, 2022
tzaffi
reviewed
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes support for the
boxesfield for appl calls in the Python SDK. Credit to @barnjamin who co-authored and started the foundation for this work.Changes:
BoxReferencetype that represents the app index (in the foreign app array) and the name of box to referencegoalcommand in this PR.TODO: