Add optimization to detect duplicates #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jasonpaulos
force-pushed
the
jason/optimize
branch
from
0fbe209
to
1cb8206
Compare
|
Closing this PR for now since it's significantly out of date. In general this is still a good idea, but not something I'm able to work on again in the near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the compiler to use the
dupanddup2ops when appropriate. The primary benefit of this optimization is to decrease the generated program size.Edit: I've identified one case where this optimization produces bad results (stateful write ops that depend on stateful reads, and the same should be true for scratch stores that depend on scratch loads). This needs to be addressed before this is ready to merge.