Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect ModelTrainer() arguments in tutorials #10

Closed
Aatlantise opened this issue May 18, 2021 · 2 comments
Closed

Incorrect ModelTrainer() arguments in tutorials #10

Aatlantise opened this issue May 18, 2021 · 2 comments

Comments

@Aatlantise
Copy link

Hello,

Thank you for your extensive tutorials. They have been very helpful.

I came across a minor error in the tutorial code, however. The first keyword argument while initializing the ModelTrainer object is a teacher model, rather than corpus. So, lines like trainer: ModelTrainer = ModelTrainer(tagger, corpus) in https://github.com/Alibaba-NLP/ACE/blob/main/resources/docs/EXPERIMENTS.md return an attribute error that can be fixed with trainer: ModelTrainer = ModelTrainer(tagger, corpus = corpus)

@wangxinyu0922
Copy link
Member

wangxinyu0922 commented May 18, 2021

Hi,

I modified the code of flair a lot, therefore please follow the README.md in the main directory to run our code. The EXPERIMENTS.md is the old guide in flair. I'm sorry for the guide that misleads you. I will delete the EXPERIMENTS.md in the next commit.

@Aatlantise
Copy link
Author

Gotcha. Thanks for your clarifications :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants