Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes on property applications #1228

Merged
merged 6 commits into from
Dec 29, 2021
Merged

Conversation

lidongze0629
Copy link
Collaborator

@lidongze0629 lidongze0629 commented Dec 28, 2021

What do these changes do?

  • Remove SSSP and BFS on property graph.
  • Rename cdlp -> lpa, lpa -> lpa_u2i, and set cdlp as the default implementation of LPA
  • make the projection step implicit in Python.
  • reserve specific apps defined on property graph, e.g., u-i lpa;
  • test and update doc of analytical engine

Related issue number

Fixes #1212
Links #1121
Links #1206
Links #1150

@lidongze0629 lidongze0629 changed the title Changes on property applications [WIP] Changes on property applications Dec 28, 2021
@lidongze0629 lidongze0629 changed the title [WIP] Changes on property applications Changes on property applications Dec 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2021

Codecov Report

Merging #1228 (9338ccc) into main (0c60e6d) will decrease coverage by 0.83%.
The diff coverage is 84.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1228      +/-   ##
==========================================
- Coverage   73.01%   72.17%   -0.84%     
==========================================
  Files          89       88       -1     
  Lines        9474     9397      -77     
==========================================
- Hits         6917     6782     -135     
- Misses       2557     2615      +58     
Impacted Files Coverage Δ
python/graphscope/analytical/app/sssp.py 100.00% <ø> (ø)
python/graphscope/framework/app.py 90.10% <0.00%> (-1.05%) ⬇️
python/graphscope/framework/context.py 65.13% <ø> (-0.92%) ⬇️
python/graphscope/tests/unittest/test_udf_app.py 38.75% <15.38%> (-0.40%) ⬇️
python/graphscope/tests/unittest/test_session.py 64.21% <25.00%> (+0.66%) ⬆️
python/graphscope/tests/unittest/test_context.py 81.03% <83.33%> (-5.98%) ⬇️
python/graphscope/analytical/app/__init__.py 100.00% <100.00%> (ø)
python/graphscope/analytical/app/bfs.py 100.00% <100.00%> (+9.09%) ⬆️
python/graphscope/analytical/app/lpa.py 100.00% <100.00%> (ø)
python/graphscope/tests/conftest.py 84.21% <100.00%> (-0.24%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c60e6d...9338ccc. Read the comment docs.

docs/analytics_engine.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@siyuan0322 siyuan0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

docs/analytics_engine.rst Show resolved Hide resolved
docs/analytics_engine.rst Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

changes on applications and their compatible graphs
5 participants