Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back mars support, re-enable mars test in CI, and fixes several related issues. #1246

Merged
merged 4 commits into from
Dec 31, 2021

Conversation

sighingnow
Copy link
Collaborator

What do these changes do?

The mars's web session is expose to the client, the default session won't work as we use the fixed backend for services when launching mars's scheduler.

The mars test is disable by default on CI, and can be enabled by export a environment variable WITH_MARS. The test case has been manually validated.

Related issue number

N/A

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2021

Codecov Report

Merging #1246 (2a331af) into main (819b970) will decrease coverage by 0.84%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1246      +/-   ##
==========================================
- Coverage   73.54%   72.69%   -0.85%     
==========================================
  Files          88       89       +1     
  Lines        9412     9453      +41     
==========================================
- Hits         6922     6872      -50     
- Misses       2490     2581      +91     
Impacted Files Coverage Δ
...n/graphscope/deploy/kubernetes/resource_builder.py 56.54% <40.00%> (-0.64%) ⬇️
python/graphscope/deploy/kubernetes/utils.py 69.04% <42.85%> (-0.52%) ⬇️
python/graphscope/config.py 100.00% <100.00%> (ø)
...thon/graphscope/tests/kubernetes/test_with_mars.py 44.82% <100.00%> (ø)
python/graphscope/analytical/app/java_app.py 24.00% <0.00%> (-45.50%) ⬇️
python/graphscope/tests/unittest/test_java_app.py 55.00% <0.00%> (-45.00%) ⬇️
python/graphscope/framework/app.py 90.10% <0.00%> (-0.53%) ⬇️
...ython/graphscope/tests/unittest/test_serailaize.py 100.00% <0.00%> (ø)
python/graphscope/framework/graph.py 84.53% <0.00%> (+4.94%) ⬆️
...on/graphscope/tests/kubernetes/test_demo_script.py 91.74% <0.00%> (+10.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 819b970...2a331af. Read the comment docs.

@sighingnow sighingnow merged commit 5331658 into alibaba:main Dec 31, 2021
@sighingnow sighingnow deleted the ht/mars branch December 31, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants