Add 'large_attr' data structure in op definition for large chunk (data of pandas/numpy) #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1303 +/- ##
==========================================
- Coverage 76.75% 73.60% -3.15%
==========================================
Files 88 88
Lines 9510 9508 -2
==========================================
- Hits 7299 6998 -301
- Misses 2211 2510 +299
Continue to review full report at Codecov.
|
sighingnow
approved these changes
Jan 27, 2022
| @@ -1058,7 +1058,7 @@ bl::result<void> GrapeInstance::registerGraphType(const rpc::GSParams& params) { | |||
| bl::result<std::shared_ptr<DispatchResult>> GrapeInstance::OnReceive( | |||
| const CommandDetail& cmd) { | |||
| auto r = std::make_shared<DispatchResult>(comm_spec_.worker_id()); | |||
| rpc::GSParams params(cmd.params); | |||
| rpc::GSParams params(cmd.params, cmd.large_attr); | |||
There was a problem hiding this comment.
Will the cmd.large_attr be copied? or just a reference?
There was a problem hiding this comment.
I will double-check any possible copy both in c++ and python side.
siyuan0322
approved these changes
Jan 27, 2022
lidongze0629
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue number
links #1290