Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a lock to protect the coordinator to avoid data race condtions. #1445

Merged
merged 3 commits into from
Apr 8, 2022

Conversation

sighingnow
Copy link
Collaborator

What do these changes do?

It's looks not striaghtfoward for add concurrent support in coordinator and grape-engine, thus we choose to force the requests come one-by-one.

Related issue number

N/A

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #1445 (c81afc6) into main (8af17df) will decrease coverage by 0.88%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1445      +/-   ##
==========================================
- Coverage   74.66%   73.77%   -0.89%     
==========================================
  Files          88       88              
  Lines        9675     9679       +4     
==========================================
- Hits         7224     7141      -83     
- Misses       2451     2538      +87     
Impacted Files Coverage Δ
python/graphscope/client/session.py 75.04% <100.00%> (-0.01%) ⬇️
...ope/analytical/app/average_shortest_path_length.py 77.77% <0.00%> (-22.23%) ⬇️
python/graphscope/framework/dag_utils.py 63.07% <0.00%> (-15.69%) ⬇️
python/graphscope/analytical/app/clustering.py 90.00% <0.00%> (-10.00%) ⬇️
python/graphscope/framework/graph_schema.py 62.58% <0.00%> (-5.76%) ⬇️
python/graphscope/framework/utils.py 66.84% <0.00%> (-2.62%) ⬇️
python/graphscope/framework/operation.py 86.11% <0.00%> (-1.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8af17df...c81afc6. Read the comment docs.

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@sighingnow sighingnow merged commit 46b30e4 into alibaba:main Apr 8, 2022
@sighingnow sighingnow deleted the ht/session-lock branch April 8, 2022 03:05
sighingnow added a commit to sighingnow/GraphScope that referenced this pull request Apr 19, 2022
See also: alibaba#1445

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
sighingnow added a commit that referenced this pull request Apr 19, 2022
See also: #1445

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants