Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a lock in the coordinator's RunStep as well. #1465

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

sighingnow
Copy link
Collaborator

What do these changes do?

See also: #1445

See also: alibaba#1445

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1465 (6e425ec) into main (0479c0a) will increase coverage by 6.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1465      +/-   ##
==========================================
+ Coverage   65.31%   71.91%   +6.59%     
==========================================
  Files          88       88              
  Lines        9702     9702              
==========================================
+ Hits         6337     6977     +640     
+ Misses       3365     2725     -640     
Impacted Files Coverage Δ
python/graphscope/framework/graph.py 84.69% <0.00%> (+0.61%) ⬆️
python/graphscope/client/utils.py 85.09% <0.00%> (+1.86%) ⬆️
python/graphscope/deploy/hosts/cluster.py 87.34% <0.00%> (+2.53%) ⬆️
python/graphscope/tests/conftest.py 82.14% <0.00%> (+4.64%) ⬆️
python/graphscope/framework/dag_utils.py 62.66% <0.00%> (+6.16%) ⬆️
python/graphscope/client/session.py 73.47% <0.00%> (+7.16%) ⬆️
python/graphscope/client/rpc.py 88.99% <0.00%> (+11.92%) ⬆️
...n/graphscope/deploy/kubernetes/resource_builder.py 56.54% <0.00%> (+25.94%) ⬆️
python/graphscope/interactive/query.py 79.83% <0.00%> (+38.70%) ⬆️
...thon/graphscope/tests/kubernetes/test_with_mars.py 44.82% <0.00%> (+44.82%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0479c0a...6e425ec. Read the comment docs.

@sighingnow sighingnow merged commit ca9c7ad into alibaba:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants