Closing the session if hearbeat fails for many times (when engine crashes) #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shes) Signed-off-by: Tao He <sighingnow@gmail.com>
| @@ -288,7 +288,7 @@ def parsed_packages(): | |||
| name = os.environ.get("package_name", "gs-coordinator") | |||
| if name == "gs-coordinator": | |||
| return find_packages(".") | |||
| return ["foo"] | |||
| return ["graphscope_runtime"] | |||
There was a problem hiding this comment.
Also change the module name 'foo' in coordinator directory
https://github.com/alibaba/GraphScope/tree/main/coordinator/foo
There was a problem hiding this comment.
Already renamed.
siyuan0322
approved these changes
Sep 28, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2088 +/- ##
==========================================
- Coverage 71.22% 71.16% -0.06%
==========================================
Files 89 89
Lines 9905 9916 +11
==========================================
+ Hits 7055 7057 +2
- Misses 2850 2859 +9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
It is quite strange to keep printing messages / exceptions like heartbeat failures when engine crashes. In this pull request, the session will be automatically closed after
self._heartbeat_maximum_failuresretires. Note thatself._heartbeat_maximum_failuresis customizable so it should fit advanced users well.This pull reqests also rename the dummy package name "foo" to "graphscope_runtime".
Related issue number
N/A