Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm could not delete role and rolebindings when uninstalling GS #2324

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

siyuan0322
Copy link
Collaborator

Helm uninstall would let role and rolebinding of GraphScope remains.

After get is added, all resources could be deleted.

@sighingnow
Copy link
Collaborator

Why mixing totally unrelated changes to this pr ...

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022

Codecov Report

Merging #2324 (16bd296) into main (d738928) will increase coverage by 31.45%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2324       +/-   ##
===========================================
+ Coverage   40.30%   71.76%   +31.45%     
===========================================
  Files          89       89               
  Lines        9937     9937               
===========================================
+ Hits         4005     7131     +3126     
+ Misses       5932     2806     -3126     
Impacted Files Coverage Δ
python/graphscope/framework/dag.py 81.63% <0.00%> (+1.02%) ⬆️
python/graphscope/client/utils.py 86.66% <0.00%> (+3.63%) ⬆️
python/graphscope/client/rpc.py 81.67% <0.00%> (+6.10%) ⬆️
python/graphscope/client/session.py 75.18% <0.00%> (+10.03%) ⬆️
python/graphscope/framework/operation.py 87.67% <0.00%> (+10.95%) ⬆️
python/graphscope/framework/graph_schema.py 64.61% <0.00%> (+11.87%) ⬆️
python/graphscope/analytical/app/bfs.py 100.00% <0.00%> (+12.50%) ⬆️
python/graphscope/framework/graph_utils.py 80.15% <0.00%> (+12.69%) ⬆️
python/graphscope/framework/errors.py 93.65% <0.00%> (+14.28%) ⬆️
python/graphscope/framework/graph.py 85.28% <0.00%> (+14.31%) ⬆️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d738928...16bd296. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants