Use ownerReferences to replace finalizers during helm uninstall #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
siyuan0322
approved these changes
Dec 26, 2022
sighingnow
approved these changes
Dec 26, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2350 +/- ##
=======================================
Coverage 40.03% 40.03%
=======================================
Files 88 88
Lines 9714 9714
=======================================
Hits 3889 3889
Misses 5825 5825 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In a real k8s cluster, we find the finalizers can't work as expected, and using ownerReferences to perform cascade deletion of role and rolebinding works fine.
Related issue number
Related #2208
Related #2324