Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the fragment loader to reuse vineyard components #2331

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

sighingnow
Copy link
Collaborator

What do these changes do?

Let the BasicFragmentLoader inherits from the vineyard ones.

Related issue number

@sighingnow sighingnow marked this pull request as draft December 15, 2022 02:29
@sighingnow sighingnow marked this pull request as ready for review December 16, 2022 01:22
@sighingnow sighingnow force-pushed the ht/upgrade-loader branch 3 times, most recently from f80be64 to 207eddd Compare December 17, 2022 10:12
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2022

Codecov Report

Merging #2331 (ccd3a56) into main (c986ea3) will decrease coverage by 31.41%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2331       +/-   ##
===========================================
- Coverage   71.66%   40.24%   -31.42%     
===========================================
  Files          89       89               
  Lines        9958     9961        +3     
===========================================
- Hits         7136     4009     -3127     
- Misses       2822     5952     +3130     
Impacted Files Coverage Δ
python/graphscope/client/rpc.py 73.88% <0.00%> (-7.80%) ⬇️
...ython/graphscope/tests/unittest/test_cython_ast.py 0.00% <0.00%> (-100.00%) ⬇️
...ython/graphscope/tests/unittest/test_serailaize.py 0.00% <0.00%> (-100.00%) ⬇️
python/graphscope/analytical/udf/patch.py 3.47% <0.00%> (-96.53%) ⬇️
python/graphscope/tests/unittest/test_lazy.py 0.00% <0.00%> (-96.19%) ⬇️
python/graphscope/tests/unittest/test_app.py 0.00% <0.00%> (-96.11%) ⬇️
...thon/graphscope/tests/unittest/test_scalability.py 0.00% <0.00%> (-96.00%) ⬇️
...hon/graphscope/tests/unittest/test_create_graph.py 0.00% <0.00%> (-92.73%) ⬇️
python/graphscope/tests/unittest/test_graph.py 0.00% <0.00%> (-85.47%) ⬇️
python/graphscope/tests/unittest/test_context.py 0.00% <0.00%> (-81.04%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c986ea3...ccd3a56. Read the comment docs.

@sighingnow sighingnow force-pushed the ht/upgrade-loader branch 3 times, most recently from 7163f5d to ee1e8d2 Compare December 19, 2022 04:02
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@sighingnow sighingnow merged commit 12a3654 into alibaba:main Dec 19, 2022
@sighingnow sighingnow deleted the ht/upgrade-loader branch December 19, 2022 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce peak memory occupation during graph construction Reduce memory usage during graph construction
3 participants