Use vineyardctl API to inject the vineyard sidecar #2612
Conversation
|
🎊 PR Preview 8d1721f has been successfully built and deployed to https://alibaba-graphscope-build-pr-2612.surge.sh 
🤖 By surge-preview |
dashanji
changed the title
dashanji
force-pushed
the
install-vineyard-as-sidecar
branch
3 times, most recently
from
1785330
to
1581da2
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2612 +/- ##
==========================================
- Coverage 73.61% 67.45% -6.17%
==========================================
Files 99 99
Lines 10392 10381 -11
==========================================
- Hits 7650 7002 -648
- Misses 2742 3379 +637 see 20 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| # 2. get the ownerReference of the coordinator | ||
| # 3. apply the etcd cluster for vineyard sidecar | ||
| # 4. return the json string of new workload which is injected with vineyard sidecar | ||
| def _inject_vineyard_as_sidecar(self, workload): |
There was a problem hiding this comment.
Could you give a sample output of the injected json in the comment? One might want to know which portion of the body will be modified and how many components would be added to that, in later development process.
There was a problem hiding this comment.
I think better to give a link to the documentation of vineyardctl.inject.
There was a problem hiding this comment.
Okay, I will add it later.
dashanji
force-pushed
the
install-vineyard-as-sidecar
branch
7 times, most recently
from
379ac2b
to
6d9a09d
Compare
dashanji
force-pushed
the
install-vineyard-as-sidecar
branch
5 times, most recently
from
c101008
to
a35746d
Compare
dashanji
force-pushed
the
install-vineyard-as-sidecar
branch
10 times, most recently
from
0195452
to
de68992
Compare
* Fix some typos in the FAQ doc. * Add the apply_resources args for vineyardctl to deploy an external etcd cluster and a vineyard rpc service. * Set up the OwnerReferences for all injected manifests of vineyardctl. * Add examples and usage about vineyardctl inject API. Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
…vineyardctl. Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
dashanji
force-pushed
the
install-vineyard-as-sidecar
branch
from
5121450
to
8d1721f
Compare
|
@siyuan0322 @sighingnow could you please take a look at this? Thanks a lot. |
🤖 Generated by Copilot at 1581da2
This pull request refactors the vineyard deployment in GraphScope to use a sidecar container instead of a separate container in the engine pod. This improves the performance and stability of the system and simplifies the management of vineyard. It also fixes some typos and errors in the documentation. The main changes are in
coordinator/gscoordinator/cluster_builder.pyandcoordinator/gscoordinator/kubernetes_launcher.py.