Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade protobuf/grpc, use newer macos builder, fixes bugs in local launcher where vineyardd may fail, use latest black as formatter #2650

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

sighingnow
Copy link
Collaborator

@sighingnow sighingnow commented Apr 25, 2023

Fixes #2657
Fixes #2634
Fixes #1550
Fixes #1554
Fixes #2258
Fixes #2626 (comment)
Fixes #2656 (comment)
Fixes #2663

@sighingnow sighingnow force-pushed the ht/build-mac branch 2 times, most recently from bd03df8 to e5ceda7 Compare April 25, 2023 11:14
@sighingnow sighingnow changed the title Build wheels using latest brew packages on CI Build Python 3.10/3.11 wheels using latest brew packages on CI Apr 25, 2023
@sighingnow sighingnow force-pushed the ht/build-mac branch 5 times, most recently from f8b3848 to 2b6b411 Compare April 25, 2023 13:13
@sighingnow sighingnow changed the title Build Python 3.10/3.11 wheels using latest brew packages on CI Upgrade protobuf/grpc, use newer macos builder, fixes bugs in local launcher where vineyardd may fail, use latest black as formatter Apr 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

Codecov Report

Merging #2650 (66d9694) into main (2657bec) will decrease coverage by 29.45%.
The diff coverage is 44.44%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2650       +/-   ##
===========================================
- Coverage   73.66%   44.22%   -29.45%     
===========================================
  Files          99       99               
  Lines       10279    10287        +8     
===========================================
- Hits         7572     4549     -3023     
- Misses       2707     5738     +3031     
Impacted Files Coverage Δ
python/graphscope/framework/graph.py 71.14% <0.00%> (-14.23%) ⬇️
python/graphscope/framework/utils.py 56.37% <50.00%> (-11.13%) ⬇️

... and 48 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2657bec...66d9694. Read the comment docs.

@sighingnow sighingnow force-pushed the ht/build-mac branch 11 times, most recently from acf07d0 to ab10b93 Compare April 27, 2023 08:19
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@sighingnow sighingnow merged commit 5c0ad71 into alibaba:main Apr 28, 2023
39 of 43 checks passed
@sighingnow sighingnow deleted the ht/build-mac branch April 28, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment