Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install jdk 11 on MacOS CI and fixes the GAE link failure in nightly CI on MacOS #2965

Merged
merged 5 commits into from Jul 4, 2023

Conversation

sighingnow
Copy link
Collaborator

What do these changes do?

Use Java 11 on CI as it is required since 30e45e0

Related issue number

Fixes https://github.com/alibaba/GraphScope/actions/runs/5447760850/jobs/9910147098

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
lidongze0629
lidongze0629 previously approved these changes Jul 4, 2023
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023

Codecov Report

Merging #2965 (94e36aa) into main (7fc14b5) will increase coverage by 31.53%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2965       +/-   ##
===========================================
+ Coverage   42.37%   73.90%   +31.53%     
===========================================
  Files          99       99               
  Lines       10649    10660       +11     
===========================================
+ Hits         4512     7878     +3366     
+ Misses       6137     2782     -3355     

see 59 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb27df4...94e36aa. Read the comment docs.

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@sighingnow sighingnow changed the title Install jdk 11 on MacOS CI Install jdk 11 on MacOS CI and fixes the GAE link failure in nightly CI on MacOS Jul 4, 2023
@sighingnow sighingnow merged commit d8ad6ce into main Jul 4, 2023
10 of 11 checks passed
@sighingnow sighingnow deleted the ht/macos-nightly-ci branch July 4, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants