Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propogate error message about argument mismatch to Python client #3044

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

sighingnow
Copy link
Collaborator

No description provided.

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@codecov-commenter
Copy link

Codecov Report

Merging #3044 (36f53eb) into main (0388da6) will decrease coverage by 31.10%.
The diff coverage is 58.82%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3044       +/-   ##
===========================================
- Coverage   73.76%   42.67%   -31.10%     
===========================================
  Files          99      100        +1     
  Lines       10701    10713       +12     
===========================================
- Hits         7894     4572     -3322     
- Misses       2807     6141     +3334     
Impacted Files Coverage Δ
python/graphscope/analytical/app/sssp.py 86.66% <0.00%> (ø)
python/graphscope/tests/unittest/test_app.py 0.00% <0.00%> (-96.94%) ⬇️
python/graphscope/analytical/app/custom.py 88.88% <88.88%> (ø)
python/graphscope/analytical/app/__init__.py 100.00% <100.00%> (ø)
python/graphscope/analytical/app/wcc.py 72.41% <100.00%> (-13.80%) ⬇️

... and 55 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0388da6...36f53eb. Read the comment docs.

@sighingnow sighingnow merged commit 185790e into alibaba:main Jul 21, 2023
22 of 26 checks passed
@sighingnow sighingnow deleted the ht/fix-argument-error branch July 21, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants