Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a flattened wrapper on property graph to run apps defined on simple graph #888

Merged
merged 38 commits into from
Nov 1, 2021
Merged

Add a flattened wrapper on property graph to run apps defined on simple graph #888

merged 38 commits into from
Nov 1, 2021

Conversation

acezen
Copy link
Collaborator

@acezen acezen commented Oct 11, 2021 •
edited

What do these changes do?

Add a wrapper on arrow property fragment to run apps defined on simple graph.
The arrow_flattened_fragment is different with arrow_projected_fragment that it's a wrapper of arrow property fragment and used to run apps on arrow property graph

Related issue number

Fixes #807

ToDo

  • coordinator compile.
  • run single label arrow property on sssp with arrow_flattened_fragment
  • implement the UnionVertexRange and UnionAdjList to iterate all label vertices and all label edges on app.
  • result context ( UnionVertexArray) , message manager (UnionDestList)
  • ForEach for UnionVertexRange, and test other apps
  • NbrDefault a wrapper for Nbr to get data with default_prop_id
  • add test cases

@acezen acezen mentioned this pull request Oct 19, 2021
Merged
@acezen
add property fragment wrapper
89a1f41 
Signed-off-by: acezen <weibin.zen@gmail.com>

test arrow_property

iterate vertex

add UnionAdjList

add UnionVertexArray

implement UnionDestList

fix UnionAdjList

refact

remove

fix python format

update
@acezen acezen changed the title [WIP] Add a wrapper on property graph to run apps defined on simple graph Add a wrapper on property graph to run apps defined on simple graph Oct 27, 2021
@acezen acezen marked this pull request as ready for review October 27, 2021 02:07
@acezen
update
b6dd2ed
@acezen
replace dataset with simple graph
cc6826b 
Signed-off-by: acezen <weibin.zen@gmail.com>
siyuan0322
siyuan0322 reviewed Oct 27, 2021
View reviewed changes
Copy link
Collaborator

@siyuan0322 siyuan0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it seems we add a new kind of fragment type called ARROW_LABEL_PROPERTY_FRAGMENT? I think it would be better you can write some introduction and use cases for it, and the COW feature. We could put this both in the documents and the release note.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
analytical_engine/apps/boundary/node_boundary.h Outdated Show resolved Hide resolved
analytical_engine/apps/boundary/utils.h Outdated Show resolved Hide resolved
python/graphscope/nx/classes/graph.py Outdated Show resolved Hide resolved
python/graphscope/nx/classes/graph.py Outdated Show resolved Hide resolved
python/graphscope/nx/classes/graph.py Outdated Show resolved Hide resolved
scripts/deploy_local.sh Outdated Show resolved Hide resolved
@acezen
update
3e7daeb
@acezen
fix
7c620ed 
Signed-off-by: acezen <weibin.zen@gmail.com>
@acezen
update
e6421eb 
Signed-off-by: acezen <weibin.zen@gmail.com>
@acezen
fix
56e0090
@acezen
update
23daccc
@acezen
rename
80c7f73
@acezen acezen mentioned this pull request Oct 27, 2021
Merged
@acezen acezen changed the title Add a wrapper on property graph to run apps defined on simple graph Add a flatten wrapper on property graph to run apps defined on simple graph Oct 28, 2021
@acezen
update
0e3219b
@acezen
update
0c32ebe
@acezen
update
3f159d4 
Signed-off-by: acezen <weibin.zen@gmail.com>
@acezen
update
d5ba0bf
@acezen
debug
cdc159c
@acezen acezen changed the title Add a flatten wrapper on property graph to run apps defined on simple graph Add a flattened wrapper on property graph to run apps defined on simple graph Oct 29, 2021
@acezen acezen merged commit d5821a1 into alibaba:main Nov 1, 2021
tianliplus pushed a commit that referenced this pull request Nov 10, 2021
@acezen @tianliplus
Add a flattened wrapper on property graph to run apps defined on simp…
684563d 
…le graph (#888)

Signed-off-by: acezen <weibin.zen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sighingnow sighingnow sighingnow approved these changes

@siyuan0322 siyuan0322 siyuan0322 left review comments

@yecol yecol yecol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NetworkX] provide a wrapper on property graph to run apps defined on simple graph
4 participants
@acezen @yecol @sighingnow @siyuan0322