-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a flattened wrapper on property graph to run apps defined on simple graph #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acezen
force-pushed
the
acezen/frag_wrapper_on_app
branch
from
October 12, 2021 02:29
8b99521
to
5619214
Compare
Signed-off-by: acezen <weibin.zen@gmail.com> test arrow_property iterate vertex add UnionAdjList add UnionVertexArray implement UnionDestList fix UnionAdjList refact remove fix python format update
acezen
force-pushed
the
acezen/frag_wrapper_on_app
branch
from
October 25, 2021 02:37
494eb39
to
89a1f41
Compare
acezen
force-pushed
the
acezen/frag_wrapper_on_app
branch
from
October 25, 2021 03:31
df27074
to
8eec7f7
Compare
acezen
force-pushed
the
acezen/frag_wrapper_on_app
branch
from
October 25, 2021 13:20
93a6be9
to
ecb081d
Compare
acezen
changed the title
[WIP] Add a wrapper on property graph to run apps defined on simple graph
Add a wrapper on property graph to run apps defined on simple graph
Oct 27, 2021
Signed-off-by: acezen <weibin.zen@gmail.com>
siyuan0322
reviewed
Oct 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it seems we add a new kind of fragment type called ARROW_LABEL_PROPERTY_FRAGMENT
? I think it would be better you can write some introduction and use cases for it, and the COW feature. We could put this both in the documents and the release note.
yecol
requested changes
Oct 27, 2021
analytical_engine/core/fragment/arrow_label_projected_fragment.h
Outdated
Show resolved
Hide resolved
analytical_engine/core/fragment/arrow_label_projected_fragment.h
Outdated
Show resolved
Hide resolved
analytical_engine/core/fragment/arrow_label_projected_fragment.h
Outdated
Show resolved
Hide resolved
sighingnow
approved these changes
Oct 27, 2021
acezen
changed the title
Add a wrapper on property graph to run apps defined on simple graph
Add a flatten wrapper on property graph to run apps defined on simple graph
Oct 28, 2021
sighingnow
reviewed
Oct 29, 2021
acezen
changed the title
Add a flatten wrapper on property graph to run apps defined on simple graph
Add a flattened wrapper on property graph to run apps defined on simple graph
Oct 29, 2021
yecol
approved these changes
Nov 1, 2021
tianliplus
pushed a commit
that referenced
this pull request
Nov 10, 2021
…le graph (#888) Signed-off-by: acezen <weibin.zen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Add a wrapper on arrow property fragment to run apps defined on simple graph.
The
arrow_flattened_fragment
is different witharrow_projected_fragment
that it's a wrapper of arrow property fragment and used to run apps on arrow property graphRelated issue number
Fixes #807
ToDo
arrow_flattened_fragment
UnionVertexRange
andUnionAdjList
to iterate all label vertices and all label edges on app.UnionVertexArray
) , message manager (UnionDestList
)ForEach
forUnionVertexRange
, and test other appsNbrDefault
a wrapper forNbr
to get data with default_prop_id