Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix opencc serialization error #83

Merged
merged 1 commit into from
Nov 17, 2023
Merged

fix opencc serialization error #83

merged 1 commit into from
Nov 17, 2023

Conversation

chenhesen
Copy link
Collaborator

fix bug for issue #81

@HYLcool HYLcool added the bug Something isn't working label Nov 17, 2023
@HYLcool HYLcool linked an issue Nov 17, 2023 that may be closed by this pull request
[Bug]: NameError: name 'fingerprint_warnings' is not defined TypeError: cannot pickle 'OpenCC' object #81
Closed
3 tasks
HYLcool
HYLcool previously approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@HYLcool HYLcool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if related tests are all passed.

The modification in this PR conflicts with PR #82 , and I will fix it in that PR.

@simplew2011
Copy link

image

好像没起效

@HYLcool HYLcool self-requested a review November 17, 2023 03:07
HYLcool
HYLcool reviewed Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@HYLcool HYLcool left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/alibaba/data-juicer/blob/9497ce51c24d75987930465c2b75dcfa3563f0e1/data_juicer/utils/fingerprint_utils.py#L57

BTW, the global varaibles fingerprint_warnings seems not "global". Please check if there is something wrong in this part.

@HYLcool HYLcool dismissed their stale review November 17, 2023 03:20

Problems still.

@chenhesen
Copy link
Collaborator Author

image

好像没起效

你好，更新完代码后，我们没有复现出该错误。
我使用的环境：
datasets==2.11.0
dill==0.3.4
opencc==1.1.6
可以检查下对应库的版本，然后删掉cache文件后再试试

@simplew2011
Copy link

datasets==2.11.0
dill==0.3.4
这两个版本引起的，已通过

HYLcool
HYLcool approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@HYLcool HYLcool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice~

@chenhesen chenhesen merged commit 62c5fb5 into main Nov 17, 2023
5 checks passed
@chenhesen chenhesen deleted the fix/opencc_serializ_error branch November 17, 2023 08:27
@jamestch jamestch mentioned this pull request Nov 21, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HYLcool HYLcool HYLcool approved these changes

@zhijianma zhijianma Awaiting requested review from zhijianma

@yxdyc yxdyc Awaiting requested review from yxdyc

Assignees

@chenhesen chenhesen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: NameError: name 'fingerprint_warnings' is not defined TypeError: cannot pickle 'OpenCC' object
3 participants
@chenhesen @simplew2011 @HYLcool