Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide utility function to verify DataFrames #79

Open
yunfengzhou-hub opened this issue Feb 24, 2023 · 0 comments
Open

Provide utility function to verify DataFrames #79

yunfengzhou-hub opened this issue Feb 24, 2023 · 0 comments
Labels
type:improvement improvement to existing functionality

Comments

@yunfengzhou-hub
Copy link
Collaborator

Currently, some tests in feathub verify a pandas DataFrame as follows.

self.assertTrue(expected_df.equals(result_df)

Such implementation cannot work in certain cases. For example, if an element in the two DataFrames is a dict whose order of entries is different, they are supposed to pass the test, while the current implementation fails in this case.

Thus we should use a better way to verify DataFrames.

@yunfengzhou-hub yunfengzhou-hub added the type:improvement improvement to existing functionality label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:improvement improvement to existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant