Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: useDeepCompareMemo #1972

Closed
wants to merge 3 commits into from
Closed

feat: useDeepCompareMemo #1972

wants to merge 3 commits into from

Conversation

Dolov
Copy link
Contributor

@Dolov Dolov commented Nov 15, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close: #2171

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Dolov
Copy link
Contributor Author

Dolov commented Nov 17, 2022

@tony 能帮忙看一下这个 pr 的报错么,我提交的代码不涉及到单元测试报错的部分,而且我本地所有的单元测试都通过了,我看代码好像也没问题。

@tony
Copy link
Contributor

tony commented Nov 17, 2022

@Dolov I assumed you intended to tag someone else?

@miracles1919
Copy link
Collaborator

我建议新增一个 createDeepCompareHook,你这个实现跟 createDeepCompareEffect 是一样的,只有 ts 定义上的差别

@Dolov Dolov closed this Dec 1, 2022
@Dolov Dolov reopened this Dec 1, 2022
@crazylxr
Copy link
Collaborator

crazylxr commented Jan 4, 2023

我建议新增一个 createDeepCompareHook,你这个实现跟 createDeepCompareEffect 是一样的,只有 ts 定义上的差别

嗯嗯,这个 hook 先不加,后面统一暴露 createDeepCompareHook。再把 深比较的 hook 都删了

@crazylxr crazylxr added the v4 label Mar 29, 2023
@xiaolifeipiao
Copy link

我建议增加扩展useCallbcak的深度监听

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

是否考虑新增一个usedeepCompareMemo
6 participants