Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DualStack feature gate and make it a build-in behavior #228

Closed
hhyasdf opened this issue Apr 19, 2022 · 2 comments
Closed

Remove DualStack feature gate and make it a build-in behavior #228

hhyasdf opened this issue Apr 19, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@hhyasdf
Copy link
Collaborator

hhyasdf commented Apr 19, 2022

Issue Description

Type: feature request

Describe what feature you want

Now, to deploy a DualStack hybridnet cluster, we need to open the DualStack feature gate by manager/webhook parameters.

But it seems now that "an ipv4-only cluster with closed DualStack feature gate" and "a dual-stack cluster (DualStack feature gate is opened) with only ipv4 subnets" are not different at all. Maybe it's time to remove the DualStack feature gate and make it a build-in feature.

Additional context

@hhyasdf
Copy link
Collaborator Author

hhyasdf commented Jun 8, 2022

Changes need to be done at the same time:

  1. IPv4 address and IPv6 address of one dual-stack Pod can be assigned with different netID
  2. Remove "status.dualStackStatistics" and dual-stack quota label

@hhyasdf
Copy link
Collaborator Author

hhyasdf commented Jun 8, 2022

Maybe unit tests of manager need to be update.

@hhyasdf hhyasdf added the enhancement New feature or request label Jun 8, 2022
@hhyasdf hhyasdf closed this as completed Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants