升级babel到7 #1280
Merged
升级babel到7 #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
chenjun1011
commented
Jan 9, 2019
chenjun1011
commented
- 兼容 bizchart 报错 Uncaught TypeError: Cannot assign to read only property 'constructor' of object '#<Group>' BizCharts#583
- 跟 ice-scripts babel配置保持一致
|
|
chenbin92
reviewed
Jan 9, 2019
| useESModules: false, | ||
| }, | ||
| ] | ||
| : null, |
There was a problem hiding this comment.
这种是项目级别特有的配置，构建运行时的，在这里无意义
chenbin92
reviewed
Jan 9, 2019
| '@babel/plugin-syntax-dynamic-import', | ||
| '@babel/plugin-syntax-import-meta', | ||
| ['@babel/plugin-proposal-class-properties', { loose: true }], | ||
| '@babel/plugin-proposal-json-strings', |
There was a problem hiding this comment.
记得 babel 7 之后可以不用显示的配置这些，可以通过 babel-preset-env 判断引用关系去做处理，不建议直接从 ice-scripts 拷贝过来，拷贝过来有两个问题：1. 需要维护两份一样的东西，可能不太合理。2. 区块开发和项目开发的构建不一样
There was a problem hiding this comment.
这些是 babel-preset-env 里不包括的
chenbin92
reviewed
Jan 9, 2019
| { libraryName: '@icedesign/base' }, | ||
| '@icedesign/base', | ||
| ], | ||
| ['babel-plugin-import', { libraryName: '@alife/next' }, '@alife/next'], |
There was a problem hiding this comment.
这句代码可以去掉，不会使用 @alife/next，我们应该只推荐使用 @alifd/next @imsobear 确认下
chenbin92
reviewed
Jan 9, 2019
|
|
||
| function resolvePlugin(plugins) { | ||
| return plugins.map((plugin) => { | ||
| return plugins.filter(Boolean).map((plugin) => { |
chenbin92
approved these changes
Jan 9, 2019
imsobear
approved these changes
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.