Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code Quality] [nacos-naming] [sub issue] improve the code quality of module nacos-naming. #5774

Closed
li-xiao-shuang opened this issue May 18, 2021 · 0 comments · Fixed by #5783 or #5784
Closed

[Code Quality] [nacos-naming] [sub issue] improve the code quality of module nacos-naming. #5774

li-xiao-shuang opened this issue May 18, 2021 · 0 comments · Fixed by #5783 or #5784
Labels
kind/code quality kind/refactor

Comments

@li-xiao-shuang
Copy link
Collaborator

li-xiao-shuang commented May 18, 2021 •
edited

Description:

Module: nacos-naming

This issue is the sub issue of #5726 , it will improve the code quality of module nacos-naming. we improve the code quality by directory.

The PR list:

dirctory pr status
cluster #5781
consistency #5783
controllers #5784
core #5914
healthcheck #5932
misc #5944
@brotherlu-xcq brotherlu-xcq mentioned this issue May 18, 2021
Closed
This was referenced May 19, 2021
Merged
Merged
Merged
KomachiSion pushed a commit that referenced this issue May 20, 2021
@li-xiao-shuang
[ISSUE #5774] improve the code quality for controllers (#5784)
35c8035 
* improve the code quality for controllers

* improve the code quality for controllers
@KomachiSion KomachiSion reopened this May 20, 2021
@li-xiao-shuang li-xiao-shuang mentioned this issue Jun 1, 2021
Merged
5 tasks
KomachiSion pushed a commit that referenced this issue Jun 3, 2021
@li-xiao-shuang
[ISSUE #5774] improve the code quality for naming core (#5914)
e199a5e 
* mprove the code quality for naming core

* fix build
This was referenced Jun 3, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/code quality kind/refactor
Projects
None yet
Milestone
No milestone
2 participants
@li-xiao-shuang @KomachiSion