Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-3917] Enhance service detail console web, add metadata filter #4439

Merged
merged 22 commits into from
Dec 21, 2020

Conversation

horizonzy
Copy link
Collaborator

What is the purpose of the change

For-#3917

@horizonzy
Copy link
Collaborator Author

Effect pictures:
image
image
image

@horizonzy
Copy link
Collaborator Author

English version.
image

@KomachiSion
Copy link
Collaborator

KomachiSion commented Dec 9, 2020

Can we do show filter in console js? The feature will cost much performance. all filter in server part is bad design.

If we do this in web console, server return all instance can share the performance pressure and if users change the filter condition, the console do not need to request again and can do filter in local memory.

@horizonzy
Copy link
Collaborator Author

If we do this in web console, server return all instance can share the performance pressure and if users change the filter condition, the console do not need to request again and can do filter in local memory.

we have thought it. If filter data just in console js.the data may exist hysteresis. If it can be accept, in console will improve performance.

@KomachiSion
Copy link
Collaborator

KomachiSion commented Dec 9, 2020

If we do this in web console, server return all instance can share the performance pressure and if users change the filter condition, the console do not need to request again and can do filter in local memory.

we have thought it. If filter data just in console js.the data may exist hysteresis. If it can be accept, in console will improve performance.

Of cource accepted. filter is just an show feature or enhancement help user to find the target instance. If user want to get newest information, they need refresh page or add other refresh button to do this.

I think this enhancement just like the Ctrl+F.

@horizonzy
Copy link
Collaborator Author

If we do this in web console, server return all instance can share the performance pressure and if users change the filter condition, the console do not need to request again and can do filter in local memory.

we have thought it. If filter data just in console js.the data may exist hysteresis. If it can be accept, in console will improve performance.

Of cource accepted. filter is just an show feature or enhancement help user to find the target instance. If user want to get newest information, they need refresh page or add other refresh button to do this.

I think this enhancement just like the Ctrl+F.

ok.

@horizonzy horizonzy closed this Dec 10, 2020
@horizonzy horizonzy reopened this Dec 10, 2020
KomachiSion
KomachiSion previously approved these changes Dec 10, 2020
@KomachiSion KomachiSion added the kind/feature type/feature label Dec 10, 2020
@KomachiSion KomachiSion added the area/Nacos console Related to Nacos consle label Dec 10, 2020
@KomachiSion KomachiSion added this to the 1.4.1 milestone Dec 10, 2020
@horizonzy horizonzy closed this Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos console Related to Nacos consle kind/feature type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants