Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console-ui config排序优化 #4599

Merged
merged 3 commits into from
Dec 31, 2020
Merged

console-ui config排序优化 #4599

merged 3 commits into from
Dec 31, 2020

Conversation

wjm0729
Copy link
Contributor

@wjm0729 wjm0729 commented Dec 29, 2020

console-ui 修改 config 列表支持排序

@CLAassistant
Copy link

CLAassistant commented Dec 29, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@wjm0729 wjm0729 closed this Dec 29, 2020
@wjm0729 wjm0729 reopened this Dec 29, 2020
KomachiSion
KomachiSion requested changes Dec 30, 2020
View reviewed changes
.gitignore Outdated
distribution/bin/logs
distribution/data
distribution/logs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this three dir is your local generation, please remove by yourself, do not submit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本地 ignore 去掉了

@KomachiSion
Copy link
Collaborator

@wjm0729 Please sign your CLA.

@wjm0729
Copy link
Contributor Author

wjm0729 commented Dec 30, 2020

Done

@KomachiSion KomachiSion merged commit dcd2fce into alibaba:develop Dec 31, 2020
@KomachiSion KomachiSion added kind/enhancement Category issues or prs related to enhancement. kind/user experience not necessarily an error but can be improved for user experience area/Nacos console Related to Nacos consle labels Dec 31, 2020
@KomachiSion KomachiSion added this to the 1.4.1 milestone Dec 31, 2020
wjm0729 added a commit to wjm0729/nacos that referenced this pull request Dec 31, 2020
@wjm0729
Merge branch 'develop' of https://github.com/alibaba/nacos into devel…
faa9fc7 
…op-import-v2

* 'develop' of https://github.com/alibaba/nacos:
  优化 FileTypeEnum 取值逻辑, 避免使用异常当作逻辑分支 (alibaba#4607)
  for alibaba#4594,alibaba#4594 Fix IO close problem. (alibaba#4606)
  console-ui config排序优化 (alibaba#4599)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KeRan213539 KeRan213539 KeRan213539 approved these changes

@KomachiSion KomachiSion KomachiSion approved these changes

@loadchange loadchange Awaiting requested review from loadchange

Assignees
No one assigned
Labels
area/Nacos console Related to Nacos consle kind/enhancement Category issues or prs related to enhancement. kind/user experience not necessarily an error but can be improved for user experience
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wjm0729 @CLAassistant @KomachiSion @KeRan213539