优化 FileTypeEnum 取值逻辑, 避免使用异常当作逻辑分支 #4607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
异常的代价是很大的, 非必要情况下. 应该尽量避免
KomachiSion
previously approved these changes
Dec 31, 2020
|
Please fix the CI problem. I see there are checkstyle problem. Please use nacos code style in source/style |
KeRan213539
requested changes
Dec 31, 2020
config/src/main/java/com/alibaba/nacos/config/server/enums/FileTypeEnum.java
Outdated
Show resolved
Hide resolved
|
解决下CI问题 |
KeRan213539
reviewed
Dec 31, 2020
test/src/test/java/com/alibaba/nacos/test/common/FileTypeEnum_ITCase.java
Show resolved
Hide resolved
|
好了, sorry |
mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true PR前可以先本地跑下这4个命令, 主要是第一个. 第一个过了格式上基本就没问题了 |
|
好的, 谢谢 |
KeRan213539
approved these changes
Dec 31, 2020
wjm0729
added a commit
to wjm0729/nacos
that referenced
this pull request
Dec 31, 2020
…op-import-v2 * 'develop' of https://github.com/alibaba/nacos: 优化 FileTypeEnum 取值逻辑, 避免使用异常当作逻辑分支 (alibaba#4607) for alibaba#4594,alibaba#4594 Fix IO close problem. (alibaba#4606) console-ui config排序优化 (alibaba#4599)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
异常的代价是很大的, 非必要情况下. 应该尽量避免