-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add nodepool and uniteddeployment api #175
add nodepool and uniteddeployment api #175
Conversation
Signed-off-by: kadisi <iamkadisi@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that you choose unit
as group name which seems to be confusing. How about just use apps
as group name?
Also, how about rename yurtunit-manager to yurt-app-manager (we may have yurt-device-manager in the future).
good idea |
@Fei-Guo PTAL |
Signed-off-by: kadisi <iamkadisi@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comments.
* add yurtunit-manager api Signed-off-by: kadisi <iamkadisi@163.com> * change unit group to apps Signed-off-by: kadisi <iamkadisi@163.com>
* add yurtunit-manager api Signed-off-by: kadisi <iamkadisi@163.com> * change unit group to apps Signed-off-by: kadisi <iamkadisi@163.com>
Ⅰ. Describe what this PR does
ref: #171
add an nodepool and uniteddeployment api.
yurtapp-manager is a kubernetes operator for nodepool and uniteddeployment.
Ⅱ. Does this pull request fix one issue?
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
@Fei-Guo @charleszheng44