Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nodepool and uniteddeployment api #175

Merged
merged 2 commits into from
Dec 25, 2020
Merged

add nodepool and uniteddeployment api #175

merged 2 commits into from
Dec 25, 2020

Conversation

kadisi
Copy link
Member

@kadisi kadisi commented Dec 22, 2020

Ⅰ. Describe what this PR does

ref: #171

add an nodepool and uniteddeployment api.

yurtapp-manager is a kubernetes operator for nodepool and uniteddeployment.

Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@Fei-Guo @charleszheng44

Signed-off-by: kadisi <iamkadisi@163.com>
@kadisi kadisi changed the title add yurtunit manager api add nodepool and uniteddeployment api Dec 22, 2020
Copy link
Member

@Fei-Guo Fei-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you choose unit as group name which seems to be confusing. How about just use apps as group name?
Also, how about rename yurtunit-manager to yurt-app-manager (we may have yurt-device-manager in the future).

@kadisi
Copy link
Member Author

kadisi commented Dec 25, 2020

It seems that you choose unit as group name which seems to be confusing. How about just use apps as group name?
Also, how about rename yurtunit-manager to yurt-app-manager (we may have yurt-device-manager in the future).

good idea

@kadisi
Copy link
Member Author

kadisi commented Dec 25, 2020

@Fei-Guo PTAL

Signed-off-by: kadisi <iamkadisi@163.com>
Copy link
Member

@Fei-Guo Fei-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments.

@Fei-Guo Fei-Guo merged commit 19e58ea into openyurtio:master Dec 25, 2020
@kadisi kadisi deleted the kadisi_yurtunit_manager_api branch December 29, 2020 03:21
wawlian pushed a commit to wawlian/openyurt that referenced this pull request Feb 8, 2021
* add yurtunit-manager api

Signed-off-by: kadisi <iamkadisi@163.com>

* change unit group to apps

Signed-off-by: kadisi <iamkadisi@163.com>
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
* add yurtunit-manager api

Signed-off-by: kadisi <iamkadisi@163.com>

* change unit group to apps

Signed-off-by: kadisi <iamkadisi@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants