Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add yurt-app-manager and Unitededeployment controller #177

Merged
merged 3 commits into from
Dec 30, 2020
Merged

add yurt-app-manager and Unitededeployment controller #177

merged 3 commits into from
Dec 30, 2020

Conversation

kadisi
Copy link
Member

@kadisi kadisi commented Dec 29, 2020

Ⅰ. Describe what this PR does

ref #171

Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Uniteddeployment now supports deployment templates.

Please review these documents in detail:

pkg/yurtappmanager/controller/uniteddeployment/uniteddeployment_controller.go
pkg/yurtappmanager/controller/uniteddeployment/adapter/deployment_adapter.go
pkg/yurtappmanager/controller/uniteddeployment/adapter/adapter.go

@Fei-Guo

Signed-off-by: kadisi <iamkadisi@163.com>
Signed-off-by: kadisi <iamkadisi@163.com>
Signed-off-by: kadisi <iamkadisi@163.com>
@Fei-Guo
Copy link
Member

Fei-Guo commented Dec 30, 2020

LG as the first change. We can do further tunings in future changes.

@Fei-Guo Fei-Guo merged commit 54daca0 into openyurtio:master Dec 30, 2020
@kadisi kadisi deleted the unitededeployment branch December 30, 2020 06:54
wawlian pushed a commit to wawlian/openyurt that referenced this pull request Feb 8, 2021
* add yurt-app-manager

Signed-off-by: kadisi <iamkadisi@163.com>

* add ud controller and webhook

Signed-off-by: kadisi <iamkadisi@163.com>

* add well known labels

Signed-off-by: kadisi <iamkadisi@163.com>
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
* add yurt-app-manager

Signed-off-by: kadisi <iamkadisi@163.com>

* add ud controller and webhook

Signed-off-by: kadisi <iamkadisi@163.com>

* add well known labels

Signed-off-by: kadisi <iamkadisi@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants