bugfix: make the jsonfile log friendly #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file related error may be os.ErrClosed. If so, we can show the container has been stopped. Signed-off-by: Wei Fu <fhfuwei@163.com>
Codecov Report
@@ Coverage Diff @@
## master #1330 +/- ##
==========================================
- Coverage 17.33% 17.32% -0.01%
==========================================
Files 189 189
Lines 11815 11818 +3
==========================================
Hits 2048 2048
- Misses 9619 9622 +3
Partials 148 148
|
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file related error may be os.ErrClosed. If so, we can show the
container has been stopped.
Signed-off-by: Wei Fu fhfuwei@163.com
Ⅰ. Describe what this PR did
Make the jsonfile log friendly.
Ⅱ. Does this pull request fix one issue?
Fixes #1325
Ⅲ. Describe how you did it
Since the error has been wrapped by the Write function, we should use the
strings.Containto check the error if it contains thefile already closed.Ⅳ. Describe how to verify it
Basically, it's hard to verify it without change the logic, because it causes by the concurrent issue:
Before jsonfile writes the data into the file, the container manager has been stopped it and closed it.
In order to make it happen, we can add the
time.SleepbeforeWrite. It will show up.Ⅴ. Special notes for reviews