-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package: add bash completion file into rpm #2253
package: add bash completion file into rpm #2253
Conversation
Codecov Report
|
Please rewrite the shell script with the rules of shellcheck. @Ace-Tang |
install bash completion when install pouch rpm. Signed-off-by: Ace-Tang <aceapril@126.com>
Codecov Report
@@ Coverage Diff @@
## master #2253 +/- ##
==========================================
- Coverage 66.7% 60.44% -6.26%
==========================================
Files 208 208
Lines 16919 16919
==========================================
- Hits 11286 10227 -1059
- Misses 4268 5450 +1182
+ Partials 1365 1242 -123
|
Updated, @allencloud . |
Codecov Report
@@ Coverage Diff @@
## master #2253 +/- ##
=========================================
+ Coverage 66.7% 66.8% +0.09%
=========================================
Files 208 208
Lines 16919 16919
=========================================
+ Hits 11286 11302 +16
+ Misses 4268 4263 -5
+ Partials 1365 1354 -11
|
LGTM |
install bash completion when install pouch rpm.
Signed-off-by: Ace-Tang aceapril@126.com
Ⅰ. Describe what this PR did
install bash completion when install pouch rpm.
For centos rpm.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
no need.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews