Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package: add bash completion file into rpm #2253

Merged
merged 1 commit into from
Oct 18, 2018
Merged

package: add bash completion file into rpm #2253

merged 1 commit into from
Oct 18, 2018

Conversation

Ace-Tang
Copy link
Contributor

install bash completion when install pouch rpm.

Signed-off-by: Ace-Tang aceapril@126.com

Ⅰ. Describe what this PR did

install bash completion when install pouch rpm.
For centos rpm.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

no need.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Sep 18, 2018

Codecov Report

❗ No coverage uploaded for pull request head (add_completion_pkg@93c1ad4). Click here to learn what that means.
The diff coverage is n/a.

@allencloud
Copy link
Collaborator

#!/bin/bash -eo pipefail
find ./ -name "*.sh" | grep -v vendor | xargs shellcheck

In ./hack/package/rpm/scripts/after-install.sh line 13:
dir="$(dirname $0)/../../../.."
               ^-- SC2086: Double quote to prevent globbing and word splitting.


In ./hack/package/rpm/scripts/after-install.sh line 18:
    cp $completion_file $dest
       ^-- SC2086: Double quote to prevent globbing and word splitting.

Please rewrite the shell script with the rules of shellcheck. @Ace-Tang
Thanks.

install bash completion when install pouch rpm.

Signed-off-by: Ace-Tang <aceapril@126.com>
@codecov
Copy link

codecov bot commented Sep 19, 2018

Codecov Report

Merging #2253 into master will decrease coverage by 6.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2253      +/-   ##
==========================================
- Coverage    66.7%   60.44%   -6.26%     
==========================================
  Files         208      208              
  Lines       16919    16919              
==========================================
- Hits        11286    10227    -1059     
- Misses       4268     5450    +1182     
+ Partials     1365     1242     -123
Flag Coverage Δ
#criv1alpha1test ?
#criv1alpha2test 35.99% <ø> (+0.02%) ⬆️
#integrationtest 39.38% <ø> (-0.13%) ⬇️
#nodee2etest ?
#unittest 23.76% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cri/v1alpha1/cri_types.go 0% <0%> (-100%) ⬇️
cri/v1alpha1/service/cri.go 0% <0%> (-84.62%) ⬇️
cri/stream/remotecommand/websocket.go 0% <0%> (-81.54%) ⬇️
cri/v1alpha1/server.go 0% <0%> (-79.2%) ⬇️
cri/v1alpha1/cri.go 0% <0%> (-61.47%) ⬇️
cri/v1alpha1/cri_wrapper.go 0% <0%> (-55.31%) ⬇️
cri/stream/remotecommand/exec.go 36.66% <0%> (-43.34%) ⬇️
cri/v1alpha1/cri_stream.go 28.57% <0%> (-37.15%) ⬇️
cri/v1alpha1/cri_utils.go 59.06% <0%> (-24.17%) ⬇️
cri/criservice.go 34.52% <0%> (-21.43%) ⬇️
... and 15 more

@Ace-Tang
Copy link
Contributor Author

Updated, @allencloud .

@codecov
Copy link

codecov bot commented Sep 19, 2018

Codecov Report

Merging #2253 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2253      +/-   ##
=========================================
+ Coverage    66.7%   66.8%   +0.09%     
=========================================
  Files         208     208              
  Lines       16919   16919              
=========================================
+ Hits        11286   11302      +16     
+ Misses       4268    4263       -5     
+ Partials     1365    1354      -11
Flag Coverage Δ
#criv1alpha1test 32.54% <ø> (+0.14%) ⬆️
#criv1alpha2test 36.11% <ø> (+0.15%) ⬆️
#integrationtest 39.47% <ø> (-0.04%) ⬇️
#nodee2etest 33.44% <ø> (+0.04%) ⬆️
#unittest 23.76% <ø> (ø) ⬆️
Impacted Files Coverage Δ
apis/server/utils.go 61.9% <0%> (-4.77%) ⬇️
daemon/mgr/system.go 76.22% <0%> (-1.64%) ⬇️
daemon/mgr/container.go 57.59% <0%> (+0.4%) ⬆️
cri/v1alpha1/cri.go 62.12% <0%> (+0.66%) ⬆️
cri/v1alpha2/cri.go 67.31% <0%> (+0.89%) ⬆️
cri/v1alpha2/cri_wrapper.go 62.4% <0%> (+2.39%) ⬆️

@zhuangqh
Copy link
Contributor

LGTM

@allencloud allencloud merged commit 16971f1 into AliyunContainerService:master Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants