Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golint:normalize some codes #2308

Merged
merged 2 commits into from
Oct 14, 2018
Merged

Conversation

Tronegacy
Copy link
Contributor

amend seven places' codes all is warning with redundant if at the end of servel “if ...; err != nil”.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

amend seven places' codes all is warning  with redundant if at the end of servel if.
@codecov
Copy link

codecov bot commented Oct 14, 2018

Codecov Report

Merging #2308 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2308      +/-   ##
==========================================
+ Coverage   66.97%   67.03%   +0.05%     
==========================================
  Files         211      211              
  Lines       17306    17292      -14     
==========================================
  Hits        11591    11591              
+ Misses       4312     4304       -8     
+ Partials     1403     1397       -6
Flag Coverage Δ
#criv1alpha1test 32.33% <57.14%> (+0.25%) ⬆️
#criv1alpha2test 35.75% <71.42%> (+0.15%) ⬆️
#integrationtest 40.25% <100%> (+0.07%) ⬆️
#nodee2etest 33.02% <57.14%> (-0.11%) ⬇️
#unittest 23.42% <28.57%> (+0.02%) ⬆️
Impacted Files Coverage Δ
storage/volume/core.go 67.14% <100%> (+0.63%) ⬆️
pkg/archive/archive.go 53.84% <100%> (+1.99%) ⬆️
daemon/mgr/spec_process.go 67.01% <100%> (+1.35%) ⬆️
daemon/mgr/container_validation.go 45.69% <100%> (+0.59%) ⬆️
daemon/mgr/spec_linux.go 75.37% <100%> (+0.9%) ⬆️
daemon/mgr/spec.go 61.9% <100%> (-3.32%) ⬇️
cri/ocicni/cni_manager.go 65% <0%> (-15%) ⬇️
cri/v1alpha2/cri_wrapper.go 61.2% <0%> (-1.2%) ⬇️
cri/v1alpha2/cri.go 65.45% <0%> (-0.88%) ⬇️
cri/v1alpha2/cri_utils.go 90.28% <0%> (-0.29%) ⬇️
... and 7 more

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @Tronegacy
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@CLAassistant
Copy link

CLAassistant commented Oct 14, 2018

CLA assistant check
All committers have signed the CLA.

@pouchrobot
Copy link
Collaborator

@Tronegacy Thanks for your contribution. 🍻
Please sign off in each of your commits.

@HusterWan
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Oct 14, 2018
@HusterWan
Copy link
Contributor

@Tronegacy Please suqash your commits, thanks a lot

@HusterWan HusterWan merged commit 35ffa0f into AliyunContainerService:master Oct 14, 2018
@HusterWan
Copy link
Contributor

@Tronegacy Please suqash your commits, thanks a lot

since the github can do squash action when merge PR, so i merged this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM one maintainer or community participant agrees to merge the pull reuqest. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants