-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
golint:normalize some codes #2308
Conversation
amend seven places' codes all is warning with redundant if at the end of servel if.
Codecov Report
@@ Coverage Diff @@
## master #2308 +/- ##
==========================================
+ Coverage 66.97% 67.03% +0.05%
==========================================
Files 211 211
Lines 17306 17292 -14
==========================================
Hits 11591 11591
+ Misses 4312 4304 -8
+ Partials 1403 1397 -6
|
We found this is your first time to contribute to Pouch, @Tronegacy |
@Tronegacy Thanks for your contribution. 🍻 |
LGTM |
@Tronegacy Please suqash your commits, thanks a lot |
since the github can do |
amend seven places' codes all is warning with redundant if at the end of servel “if ...; err != nil”.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews