-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Italicised exclaimation ! is slanting the wrong way #187
Comments
I can't replicate the issue with the exclamation point in Amiri. I actually get a non-italicized glyph in the Italic style: Test code (typeset in SILE): \begin{document}
\font[size=60pt]
\raggedright{
\font[family=Montserrat,size=12pt]{Amiri, 60pt}\break
\font[family=Amiri]{Fresh fish!}\break
\font[family=Amiri,style=Italic]{Fresh fish!}\break
}
\end{document} I suspect the backwards glyph might actually be whatever program you are using doing some kind of fallback action. What are you using anyway? Meanwhile I thought I would chime in to let you know that the version of Crimson Text you are comparing too is obscenely old. There was a major overhaul released some years after the version you are testing with there (now usually just known as Crimson without the 'Text'). Some years after than just a little while back there was another overhaul, this time including a variable font version, this time released as Crimson Pro. I don't know which edition Amiri pulled glyphs from, but it seems to be newer that the version you are comparing too. If you goal is a font for Latin output, you're probably better off using one of the newer Crimson sources instead. Here are samples of 400 weight Roman and Italic styles from each: Interesting to see that the Plus the SILE code used to generate the sample: \begin{document}
\font[size=60pt]
\raggedright{
\font[family=Montserrat,size=12pt]{Crimson, 60pt}\break
\font[family=Crimson]{Fresh fish!}\break
\font[family=Crimson,style=Italic]{Fresh fish!}\break
\font[family=Montserrat,size=12pt]{Crimson Pro, 60pt}\break
\font[family=Crimson Pro]{Fresh fish!}\break
\font[family=Crimson Pro,style=Italic]{Fresh fish!}\break
}
\end{document} |
The TTFs seem ok on Windows and MS-office but the web fonts are showing up with the incorrect slant. I see it in Chrome, Firefox, Edge (all on Windows). It is the same for both the google fonts page and amirifont.org (if I add an exclamation mark). I'm not sure if the browsers use the TTFs or some other format - maybe that is the difference? |
How are you using the font? Looks like you are getting the old version from Google Fonts. |
@khaledhosny He does have a point that https://www.amirifont.org has the same problem, so however you are getting it there... |
The website uses the font from Google Fonts (for simplicity), I can make it use the fonts from the repo. But I thought he meant downloading the fonts from the links on the website, otherwise that is a very complicated way to test the font :) |
I was mistaken to think that the amirifont.org website would be using the latest version. I have converted the latest build 0.112 to woff2 (using font-converter.net) and it's better so I guess it is a problem with google's version. Result is below. The exclamation point is better but I think the numbers are regressed - I am ok with that for now. Just to add that we really appreciate the work you have done with this font. We have been using it for both Arabic and Latin content on our blog to book service (pixxibook.com) and it looks great in print. |
Happy this is figured out.
Can you elaborate? |
The numbers aren't italicised. It's the same on the google fonts version but on google fonts version 123ish (with letters) is italicised. In this test case it wasn't. The spacing looks different too. |
Numbers should be slanted, but there was a bug in the OpenType code, should be fixed now. If you don’t like the tabular spacing, you can enable the |
Exclaimation mark in italic slopes left instead of right. Tested on google fonts and also with the version on amirifont.org
I believe that these Latin chars are derived from CrimsonText but it is ok there. The kerning and ligatures on Amiri are much nicer though.
Amiri:
Crimson Text:
The text was updated successfully, but these errors were encountered: