Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rust] Row support more types #1202

Merged
merged 2 commits into from
Dec 3, 2023
Merged

[Rust] Row support more types #1202

merged 2 commits into from
Dec 3, 2023

Conversation

theweipeng
Copy link
Member

@theweipeng theweipeng commented Dec 3, 2023 •
edited
Loading

What do these changes do?

Support int8, int16, int32, int64, binary, string, list, date32, and date64.

Related issue number

Close #1201

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

chaokunyang
chaokunyang approved these changes Dec 3, 2023
View reviewed changes
Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work, @wangweipeng2

@chaokunyang chaokunyang merged commit c45f407 into apache:main Dec 3, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaokunyang chaokunyang chaokunyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Rust] support more types for row format
2 participants
@theweipeng @chaokunyang