Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Refine py register class method #1218

Merged
merged 4 commits into from
Dec 8, 2023
Merged

[Python] Refine py register class method #1218

merged 4 commits into from
Dec 8, 2023

Conversation

chaokunyang
Copy link
Collaborator

@chaokunyang chaokunyang commented Dec 8, 2023 •
edited
Loading

What do these changes do?

Refine py register class method by merge class_tag and class_id together

Related issue number

Closes #1217
Closes #1219

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

theweipeng
theweipeng approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@theweipeng theweipeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaokunyang chaokunyang merged commit bd7e234 into apache:main Dec 8, 2023
16 checks passed
@chaokunyang chaokunyang deleted the merge_py_register_class_methods branch April 1, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theweipeng theweipeng theweipeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Python] Refine py register class method Python example in README fails
2 participants
@chaokunyang @theweipeng