Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ Rust ] Make the protocols of rust and js consistent #738

Merged
merged 2 commits into from
Jul 23, 2023
Merged

[ Rust ] Make the protocols of rust and js consistent #738

merged 2 commits into from
Jul 23, 2023

Conversation

theweipeng
Copy link
Member

What do these changes do?

Make the protocols of rust and js consistent.

  • update the hashing algorithm, now it calculates correctly.
  • add xlang test. rust should be able to decode binary from python.
  • vec updated to use var_int32

Related issue number

#737

@theweipeng theweipeng changed the title [ Rust | Javascript ] Make the protocols of rust and js consistent [ Rust ] Make the protocols of rust and js consistent Jul 23, 2023
@theweipeng theweipeng merged commit 04bf9d6 into apache:main Jul 23, 2023
10 checks passed
@theweipeng theweipeng deleted the consistent_py branch July 23, 2023 12:10
@theweipeng theweipeng mentioned this pull request Jul 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaokunyang chaokunyang Awaiting requested review from chaokunyang chaokunyang is a code owner

Assignees

@chaokunyang chaokunyang

Labels
javascript rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theweipeng @chaokunyang