[Java] replace withSecureMode by requireClassRegistration API #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tisonkun Could you help review this PR? |
tisonkun
reviewed
Jul 26, 2023
There was a problem hiding this comment.
While withSecureMode(false) is vague and even ambiguous, is it possible with use requireClassRegistration to replace all the usage of withSecureMode instead and document requireClassRegistration(false)'s safety requirement (i.e., "your environment is indeed secure")?
I don't know if withSecureMode has other meaning - it reads vague and ambiguous to me. Here we can expose the real effect requireClassRegistration that is not an internal concept but what users modify the option need to know.
|
Good suggestion, |
chaokunyang
changed the title
tisonkun
approved these changes
Jul 26, 2023
chaokunyang
force-pushed
the
remove_require_class_registration
branch
from
050d731
to
ebef6de
Compare
This was referenced Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
remove requireClassRegistration API
Related issue number
Closes #769
Check code requirements