Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pick 2.4.8 lost code #315

Merged
merged 1 commit into from
Jan 2, 2019

Conversation

straybirdzls
Copy link
Member

fix #314

@straybirdzls straybirdzls added the bug Something isn't working label Dec 28, 2018
@straybirdzls straybirdzls added this to the 2.6.0 milestone Dec 28, 2018
@coveralls
Copy link

coveralls commented Dec 28, 2018

Pull Request Test Coverage Report for Build 671

  • 8 of 26 (30.77%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 71.54%

Changes Missing Coverage Covered Lines Changed/Added Lines %
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/spi/log/SofaLogger.java 0 2 0.0%
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/spring/factory/AbstractContractFactoryBean.java 7 12 58.33%
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/component/impl/ComponentManagerImpl.java 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/spring/factory/AbstractContractFactoryBean.java 1 50.72%
Totals Coverage Status
Change from base Build 664: -0.5%
Covered Lines: 1644
Relevant Lines: 2298

💛 - Coveralls

@straybirdzls straybirdzls self-assigned this Dec 29, 2018
@caojie09 caojie09 merged commit aeba1f1 into sofastack:2.x Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants