Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for duplicate isle module #326

Merged
merged 1 commit into from
Jan 9, 2019

Conversation

straybirdzls
Copy link
Member

fix #299

@straybirdzls straybirdzls added the bug Something isn't working label Jan 2, 2019
@straybirdzls straybirdzls added this to the 2.6.0 milestone Jan 2, 2019
@straybirdzls straybirdzls self-assigned this Jan 2, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 689

  • 5 of 7 (71.43%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 72.234%

Changes Missing Coverage Covered Lines Changed/Added Lines %
isle-sofa-boot-starter/src/main/java/com/alipay/sofa/isle/deployment/impl/AbstractDeploymentDescriptor.java 5 7 71.43%
Totals Coverage Status
Change from base Build 664: 0.2%
Covered Lines: 1652
Relevant Lines: 2287

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 689

  • 5 of 7 (71.43%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 72.234%

Changes Missing Coverage Covered Lines Changed/Added Lines %
isle-sofa-boot-starter/src/main/java/com/alipay/sofa/isle/deployment/impl/AbstractDeploymentDescriptor.java 5 7 71.43%
Totals Coverage Status
Change from base Build 664: 0.2%
Covered Lines: 1652
Relevant Lines: 2287

💛 - Coveralls

Copy link
Contributor

@glmapper glmapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@QilongZhang QilongZhang merged commit ca08e52 into sofastack:2.x Jan 9, 2019
QilongZhang pushed a commit to QilongZhang/sofa-boot that referenced this pull request Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants