Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to 1.5.1 and do some refactors #41

Merged
merged 65 commits into from
Sep 21, 2018
Merged

upgrade to 1.5.1 and do some refactors #41

merged 65 commits into from
Sep 21, 2018

Conversation

luyiisme
Copy link
Contributor

Motivation:

optimze

Modification:

  • Reduce configuration operations when use DefaultLookoutclient and lookoutRegistry;
  • Fix a debug log NPE (in 1.5.0) ,when check a valid gateway server;
  • Upgrade client version to 1.5.1

@coveralls
Copy link

coveralls commented Sep 18, 2018

Pull Request Test Coverage Report for Build 93

  • 16 of 19 (84.21%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 67.795%

Changes Missing Coverage Covered Lines Changed/Added Lines %
client/lookout-reg-server/src/main/java/com/alipay/lookout/remote/report/support/http/ReportDecider.java 7 8 87.5%
client/lookout-reg-server/src/main/java/com/alipay/lookout/remote/report/support/http/DefaultHttpRequestProcessor.java 5 7 71.43%
Files with Coverage Reduction New Missed Lines %
client/lookout-reg-server/src/main/java/com/alipay/lookout/remote/report/support/http/DefaultHttpRequestProcessor.java 2 51.58%
Totals Coverage Status
Change from base Build 91: 0.06%
Covered Lines: 2583
Relevant Lines: 3810

💛 - Coveralls

@luyiisme luyiisme merged commit 5852af0 into sofastack:master Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants