Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

Add serlize type support in annotation #118

Merged
merged 4 commits into from
Nov 21, 2018

Conversation

khotyn
Copy link
Member

@khotyn khotyn commented Nov 20, 2018

Motivation:

Add serialize type support in annotation

Modification:

Add serialize type parse code in RpcBindingConverter when parse reference and service configuration.

Result:

Fixes issue #116

Add serlize type support in annotation

Fix issue #116
Debug test case
change the rpc.starter.version value to fix the failed test case in ci.
@khotyn khotyn added this to the 6.0.1 milestone Nov 20, 2018
@khotyn khotyn added the enhancement New feature or request label Nov 20, 2018
@codecov
Copy link

codecov bot commented Nov 20, 2018

Codecov Report

Merging #118 into 6.x will increase coverage by 1.36%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                6.x     #118      +/-   ##
============================================
+ Coverage     54.87%   56.23%   +1.36%     
- Complexity      392      402      +10     
============================================
  Files            53       53              
  Lines          1735     1739       +4     
  Branches        309      311       +2     
============================================
+ Hits            952      978      +26     
+ Misses          603      579      -24     
- Partials        180      182       +2
Impacted Files Coverage Δ Complexity Δ
...pc/boot/runtime/converter/RpcBindingConverter.java 49.54% <100%> (+5.56%) 27 <0> (+4) ⬆️
...t/runtime/adapter/helper/ConsumerConfigHelper.java 56.88% <0%> (+1.83%) 15% <0%> (+1%) ⬆️
...y/sofa/rpc/boot/runtime/param/RpcBindingParam.java 41.42% <0%> (+2.14%) 45% <0%> (+2%) ⬆️
...t/runtime/adapter/helper/ProviderConfigHelper.java 49.33% <0%> (+4%) 7% <0%> (+2%) ⬆️
...c/boot/runtime/converter/BoltBindingConverter.java 100% <0%> (+30.76%) 7% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d46330...f67dc66. Read the comment docs.

@leizhiyuan leizhiyuan merged commit 16ca9b5 into 6.x Nov 21, 2018
@leizhiyuan leizhiyuan deleted the add_serialize_type_annotation_support branch November 25, 2018 23:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants