Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception message is not exactly #374

Closed
OrezzerO opened this issue Nov 26, 2018 · 3 comments
Closed

Exception message is not exactly #374

OrezzerO opened this issue Nov 26, 2018 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@OrezzerO
Copy link
Contributor

Describe the bug

In FilterInvoker ,according to the context "Next filter or invoker is null!" should be "Next filter and invoker is null!"

   @Override
    public SofaResponse invoke(SofaRequest request) throws SofaRpcException {
        if (nextFilter == null && invoker == null) {
            throw new SofaRpcException(RpcErrorType.SERVER_FILTER, "Next filter or invoker is null!");
        }
        return nextFilter == null ?
            invoker.invoke(request) :
            nextFilter.invoke(invoker, request);
    }

Expected behavior

Actual behavior

Steps to reproduce

Minimal yet complete reproducer code (or GitHub URL to code)

Environment

  • SOFARPC version: 5.4.7
  • JVM version (e.g. java -version):
  • OS version (e.g. uname -a):
  • Maven version:
  • IDE version:
@khotyn khotyn added the enhancement New feature or request label Nov 26, 2018
@khotyn
Copy link
Member

khotyn commented Nov 26, 2018

@OrezzerO Would you like to send a PR to fix this problem? We are extremely welcome your PR. 😆

@OrezzerO
Copy link
Contributor Author

@khotyn OK,I will try it.

@leizhiyuan leizhiyuan added this to the 5.4.8 milestone Dec 3, 2018
@leizhiyuan leizhiyuan mentioned this issue Dec 3, 2018
@leizhiyuan
Copy link
Contributor

we need to release 5.4.8 this week。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants