Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix LocalRegistryHelper#checkModified returns true even if the file has not changed #413

Merged
merged 1 commit into from
Dec 11, 2018

Conversation

ScienJus
Copy link
Member

fix #412

@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

Merging #413 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #413      +/-   ##
===========================================
+ Coverage     70.16%   70.2%   +0.03%     
- Complexity     1094    1097       +3     
===========================================
  Files           368     368              
  Lines         15602   15602              
  Branches       2523    2524       +1     
===========================================
+ Hits          10947   10953       +6     
+ Misses         3331    3327       -4     
+ Partials       1324    1322       -2
Impacted Files Coverage Δ Complexity Δ
...y/sofa/rpc/registry/local/LocalRegistryHelper.java 47.36% <100%> (+1.5%) 14 <0> (+2) ⬆️
...m/alipay/sofa/rpc/module/FaultToleranceModule.java 66.66% <0%> (-26.67%) 4% <0%> (-1%)
...pc/transport/bolt/BoltClientConnectionManager.java 73.97% <0%> (-2.74%) 22% <0%> (-1%)
.../main/java/com/alipay/sofa/rpc/event/EventBus.java 71.73% <0%> (-2.18%) 0% <0%> (ø)
...ipay/sofa/rpc/tracer/sofatracer/RpcSofaTracer.java 87.06% <0%> (+0.94%) 0% <0%> (ø) ⬇️
...pay/sofa/rpc/transport/ClientTransportFactory.java 78.46% <0%> (+1.53%) 0% <0%> (ø) ⬇️
...ipay/sofa/rpc/server/bolt/BoltServerProcessor.java 72.8% <0%> (+5.59%) 26% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fefb12e...bad7a7a. Read the comment docs.

@leizhiyuan
Copy link
Contributor

Thanks

@leizhiyuan leizhiyuan requested review from leizhiyuan, NeGnail, caojie09 and JervyShi and removed request for leizhiyuan and caojie09 December 11, 2018 03:57
Copy link
Member

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@leizhiyuan leizhiyuan removed the request for review from JervyShi December 11, 2018 03:59
Copy link
Contributor

@NeGnail NeGnail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@leizhiyuan leizhiyuan merged commit 5f9d4b4 into sofastack:master Dec 11, 2018
@leizhiyuan leizhiyuan added this to the 5.5.0 milestone Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LocalRegistryHelper#checkModified returns true even if the file has not changed
4 participants