-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize async thread pool execute #415
optimize async thread pool execute #415
Conversation
Codecov Report
@@ Coverage Diff @@
## master #415 +/- ##
============================================
- Coverage 70.99% 70.99% -0.01%
- Complexity 1107 1110 +3
============================================
Files 368 368
Lines 15472 15478 +6
Branches 2501 2501
============================================
+ Hits 10984 10988 +4
- Misses 3157 3161 +4
+ Partials 1331 1329 -2
Continue to review full report at Codecov.
|
}); | ||
} catch (RejectedExecutionException e) { | ||
LOGGER | ||
.warn("this queue is full when post event to async execute.please optimize this AsyncThreadPool"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
首字母大写,英文标点后面加空格。
警告的时候是否考虑输出线程池当前情况?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
改了,加了一下queue的打印。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Motivation:
Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #391
If there is no issue then describe the changes introduced by this PR.