Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize async thread pool execute #415

Merged
merged 5 commits into from
Dec 13, 2018
Merged

optimize async thread pool execute #415

merged 5 commits into from
Dec 13, 2018

Conversation

leizhiyuan
Copy link
Contributor

Motivation:

Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #391

If there is no issue then describe the changes introduced by this PR.

@leizhiyuan leizhiyuan added this to the 5.5.0 milestone Dec 11, 2018
@leizhiyuan leizhiyuan added the enhancement New feature or request label Dec 11, 2018
@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

Merging #415 into master will decrease coverage by <.01%.
The diff coverage is 53.84%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #415      +/-   ##
============================================
- Coverage     70.99%   70.99%   -0.01%     
- Complexity     1107     1110       +3     
============================================
  Files           368      368              
  Lines         15472    15478       +6     
  Branches       2501     2501              
============================================
+ Hits          10984    10988       +4     
- Misses         3157     3161       +4     
+ Partials       1331     1329       -2
Impacted Files Coverage Δ Complexity Δ
.../main/java/com/alipay/sofa/rpc/event/EventBus.java 69.23% <53.84%> (-4.69%) 0 <0> (ø)
...alipay/sofa/rpc/registry/zk/ZookeeperRegistry.java 58.67% <0%> (-0.64%) 0% <0%> (ø)
...va/com/alipay/sofa/rpc/server/bolt/BoltServer.java 73.33% <0%> (+1.11%) 24% <0%> (+1%) ⬆️
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java 82.14% <0%> (+1.78%) 0% <0%> (ø) ⬇️
...sian/MultipleClassLoaderSofaSerializerFactory.java 100% <0%> (+13.33%) 6% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fde88d5...14945f1. Read the comment docs.

});
} catch (RejectedExecutionException e) {
LOGGER
.warn("this queue is full when post event to async execute.please optimize this AsyncThreadPool");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

首字母大写,英文标点后面加空格。

警告的时候是否考虑输出线程池当前情况?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改了,加了一下queue的打印。

Copy link
Member

@JervyShi JervyShi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@NeGnail NeGnail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@leizhiyuan leizhiyuan merged commit c6f5504 into sofastack:master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants